#141680: "incorrect score display"
Tentang apa laporan ini?
Apa yang terjadi? Pilih di bawah
Apa yang terjadi? Pilih di bawah
Silakan periksa apakah sudah ada laporan tentang hal yang sama
Jika ya, silakan VOTE untuk laporan ini. Laporan dengan suara terbanyak diberikan PRIORITAS!
| # | Status | Votes | Game | Type | Title | Last update |
|---|
Detil Deskripsi
-
• Mohon salin/tempel pesan error yang Anda lihat di layar, jika ada.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Mohon jelaskan apa yang ingin Anda lakukan, apa yang kemudian Anda lakukan, dan apa yang terjadi
• Apa browser yang Anda gunakan?
opera
-
• Harap salin/tempel teks yang ditampilkan dalam bahasa Inggris alih-alih bahasa anda. Jika Anda memiliki screenshot bug ini (disarankan), Anda dapat menggunakan Imgur.com untuk menguploadnya dan memberi tautannya di sini.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• apakah teks ini tersedia dalam translation system? jika iya, itu bisa diartikan lebih dari 24 jam
• Apa browser yang Anda gunakan?
opera
-
• Tolong jelaskan saran Anda secara tepat dan ringkas sehingga semudah mungkin untuk memahami apa yang Anda maksud.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Apa browser yang Anda gunakan?
opera
-
• Apa yang tampil di layar ketika Anda tidak dapat berjalan (Layar kosong? Hanya tampil sebagian antar-muka? Pesan error?)
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Apa browser yang Anda gunakan?
opera
-
• Bagian mana dari peraturan yang tidak diterapkan dengan tepat oleh BGA
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Apakah kesalahan peraturan dapat dilihat dari ulangan permainan? Jika ya, pada langkah ke berapa?
• Apa browser yang Anda gunakan?
opera
-
• Aksi permainan apa yang ingin Anda lakukan?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Apa yang Anda coba lakukan untuk memunculkan aksi permainan ini?
-
• Apa yang terjadi ketika Anda melakukannya (pesan error, pesan status permainan, ...)?
• Apa browser yang Anda gunakan?
opera
-
• Pada langkah ke berapa masalah tersebut muncul (apa petunjuk permainan saat itu)?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Apa yang terjadi ketika Anda mencoba untuk melakukan aksi permainan (pesan error, pesan status permainan, ...)?
• Apa browser yang Anda gunakan?
opera
-
• Mohon jelaskan masalah tampilannya. Jika Anda memiliki screenshot bug ini (disarankan), Anda dapat menggunakan Imgur.com untuk menguploadnya dan memberi tautannya di sini.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Apa browser yang Anda gunakan?
opera
-
• Harap salin/tempel teks yang ditampilkan dalam bahasa Inggris alih-alih bahasa anda. Jika Anda memiliki screenshot bug ini (disarankan), Anda dapat menggunakan Imgur.com untuk menguploadnya dan memberi tautannya di sini.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• apakah teks ini tersedia dalam translation system? jika iya, itu bisa diartikan lebih dari 24 jam
• Apa browser yang Anda gunakan?
opera
-
• Tolong jelaskan saran Anda secara tepat dan ringkas sehingga semudah mungkin untuk memahami apa yang Anda maksud.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Apa browser yang Anda gunakan?
opera
Laporkan riwayat
- From the location cards image, it looks like happens in night phase.
- The left lane location number is set to `2` even though there isn't any card that modifies the number (it should be 1 in that case).
- The center lane location number is set to `3` even though `Maat` is presented (it should be 5 in that case).
Possibly there are two issues.
1. Plotting number is wrongly done in some case?
2. Day / Night state is wrongly set in some case? (while restoring game?)
1. This happened in 2nd round.
2. After browser refresh, it displayed correct result (this means the game state is restored correctly).
3. Replay from previous round did not reproduced the bug.
4. Wrongly displayed result was different from previous round result. i.e. This is not a bug that displays previous round result.
This needs further investigation.
github.com/giantroach/sunrisesunset/blob/v0.4/bga_src/backend/sunrisesunset.game.php#L1092
1. `'i18n' => ['lane'],` makes `lane` arg to be translated.
en.doc.boardgamearena.com/Translations
2. This `lane` arg is referred in client side code. And that expects one of `left`, `right` or `center`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L304
If a player is playing in other than English language (in my case Japanese), this logic won't work.
Though, it is weird that it displayed win / lose / tie on screen in this case.
1. scoreData.result is reset every `newRound`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L50
2. Displaying result logic explicitly checking the scoreData.result value without fallback.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/state.ts#L825-L841
So I suspect this is not yet everything.
1. As I mentioned above, lane translation is one of the cause of this issue. Due to this bug, win / lose / draw is usually not be displayed when you are playing the game with other than English language.
2. When you restore the game state, score data from previous round will be restored. Current game logic is expecting to have those score data to be emptied every new round. So this is an unexpected state.
3. When score data isn't empty and when game state goes endRound, it immediately proceeds to display the game result, without waiting any other process.
4. Changing of state does not have any delay, unlike the notification handler that has max 1sec of intentional delay (to let player observe what is happening), so this causes displaying prev round score data mixed with current round data!
1. and 2. should be fixed. Do not restore the score data unless it is endRound state.
Translation of lane name is partly disabled due to this fix and currently it is inconsistent.
This translation issue will be dealt separately.
Tambahkan hal lain di laporan ini
- ID meja / nomor langkah lainnya
- Apakah F5 menyelesaikan masalah?
- Apakah masalah tersebut telah muncul beberapa kali? Setiap kali? Tidak tentu?
- Jika Anda memiliki screenshot bug ini (disarankan), Anda dapat menggunakan Imgur.com untuk menguploadnya dan memberi tautannya di sini.
